Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop,Mobile: Resolves #10031: Upgrade CodeMirror 6 packages #10032

Merged
merged 2 commits into from Mar 4, 2024

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Mar 1, 2024

Summary

Upgrades CodeMirror 6 packages, resolving #10031.

Notes

This pull request does not update @codemirror/language-data -- doing so increases the mobile bundle size from 1.7 MB to 2.2 MB. Additionally, it seems to trigger Webpack's chuncking mechanism (though we can disable it with output.chunkFormat = false).

Testing

  1. Create a new document with the following content:
# Test

>
> This is a block quote.
>

Should have link formatting:
[This is a link](https://joplinapp.org/). https://this.is.a.test.joplinapp.org/

Should auto-renumber:
1. This
2. is
    1. This
    2. is
    3. a
    4. test
5. a
6. list
7. testing...


`shouldnotspellcheck` Should spllchek.

```javascript
function foo() {
    // This should be highlighted.
}
```

# Test 2
## Test 3
### Test 4

```yaml
a:
    b:
    - c
    - d
```

| a | b | c|
|---|---|--|
|  |   |   |
|test| | |
  1. Verify that links, code blocks, headings, and block quotes have the correct styling in the beta editor.
  2. Verify that the table is in a monospaced font.
  3. Verify that numbered list continuation works.
  4. Select everything
    • Verify that "select all" works on iOS
  5. Duplicate it
  6. Repeat steps 5 and 6 three more times.
  7. (Desktop only) Enable vim keyboard emulation
  8. Jump to the top of the document (gg) then to the end (G)
  9. Go to the middle of the numbered list
  10. Open a new line (o)

This has been tested successfully on:

  • Ubuntu 23.10
  • Android 13
  • iOS

Note: On iOS, the inline code region is spellchecked (despite having spellcheck="false"), but this doesn't seem to be a regression (comparing with latest beta).

Does not update `@codemirror/language-data` -- doing so increases the
mobile bundle size from 1.7 MB to 2.2 MB. Additionally, it seems to
trigger Webpack's chuncking mechanism (though we can disable it with
`output.chunkFormat = false`).
@laurent22
Copy link
Owner

Conflict on yarn.lock

@laurent22 laurent22 merged commit dfc08da into laurent22:dev Mar 4, 2024
10 checks passed
@laurent22
Copy link
Owner

Thanks for updating this! Do you know if it also fixes this bug #9675?

@personalizedrefrigerator
Copy link
Collaborator Author

personalizedrefrigerator commented Apr 15, 2024

Thanks for updating this! Do you know if it also fixes this bug #9675?

#9675 seems to be fixed! (It may alternatively have been fixed by #10174).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants