Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All: Bump @codemirror/view version. #10174

Merged
merged 4 commits into from Mar 23, 2024
Merged

Conversation

itzTheMeow
Copy link
Contributor

Fixes #10043. (i'm not aware of any other issues this affects)

Bumps the @codemirror/view version to 6.26.0 for the editor.

Avoid the editor getting confused when iOS autocorrects on pressing Enter and does the correction and the break insertion in two different events.

Copy link
Contributor

github-actions bot commented Mar 21, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@itzTheMeow
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Mar 21, 2024
@personalizedrefrigerator
Copy link
Collaborator

Thank you for contributing!

Here are a few notes:

  • Be sure to also update yarn.lock (e.g. by running yarn install and committing the result).
  • If tests fail after this, it may be necessary to remove all @codemirror/ and @lezer/ dependencies from yarn.lock, then re-run yarn install.

See also:

  • The comment for the relevant regression test:
    // This checks for a regression -- occasionally, when updating packages,
    // syntax highlighting in the CodeMirror editor stops working. This is usually
    // fixed by
    // 1. removing all `@codemirror/` and `@lezer/` dependencies from yarn.lock,
    // 2. upgrading all CodeMirror packages to the latest versions in package.json, and
    // 3. re-running `yarn install`.
    //
    // See https://github.com/laurent22/joplin/issues/7253
    it('should give headings a different style', async () => {
  • A related thread on the CodeMirror forum.

@laurent22
Copy link
Owner

CI is passing now. Does that look good to you now @personalizedrefrigerator?

@personalizedrefrigerator
Copy link
Collaborator

CI is passing now. Does that look good to you now @personalizedrefrigerator?

I haven't tested this locally, but since the automated tests are passing, this looks good to me!

@laurent22
Copy link
Owner

Great, let's merge then!

@laurent22 laurent22 merged commit b936f9b into laurent22:dev Mar 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS: Autocorrect inserts 2 line breaks.
3 participants