Mobile: Can't empty trash

[personalizedrefrigerator]

Operating system

Android

Joplin version

3.0.0

Desktop version info

No response

Current behaviour

To reproduce,

1. Move a folder to the trash
2. Long-press on the trash folder
3. Long-press on the new subfolder of the trash folder

Currently,

1. The trash folder has no long-press menu
2. The subfolder of trash does not have a "permanently delete" option.

Expected behaviour

As on desktop, it should be possible to

1. Delete folders from the trash notebook, or
2. Clear all items in the trash notebook (including folders).

Logs

No response

[Sidd-R]

Hello, I wish to work on this issue. I am trying for gsoc this year and the guidelines state that one cannot submit another pull request before the previous one is merged and my previous pull request is yet to be merged. So, can I start working on this or should I wait for the previous pr to get merged?

[PackElend]

Dépending on the quality of the open PR.
If it has a lot of comments and you start the same way again, your next PR could be closed immediately

[Sidd-R]

Dépending on the quality of the open PR. If it has a lot of comments and you start the same way again, your next PR could be closed immediately

Okay, got it. I'll keep that in mind. If there are any issues with the quality of the pr then can you please point it out so that I can improve on it next pr onwards.

[Sidd-R]

HI! I have completed the Implementation of this feature. I have added all the above mentioned features, apart from these I have also added an option to delete individual notes permanently and to restore all folders/notes from trash on long press. Requesting feedback for the same. If all is okay, then I'll create a pr.

permanent_delete_demo.mp4

[personalizedrefrigerator]

I have added all the above mentioned features, apart from these I have also added an option to delete individual notes permanently and to restore all folders/notes from trash on long press. Requesting feedback for the same. If all is okay, then I'll create a pr.

That looks good to me! @laurent22 do you have any comments on the proposed design?

[laurent22]

Yes I'm fine with it but there are multiple features in this video and there should be only one per PR. So @Sidd-R feel free to create a pull request but only for the "empty trash" feature (no "restore all", etc.)

[Sidd-R]

only for the "empty trash" feature

okay got it. Also, should I wait for separate issues for the other features in the video to be created? or should I create multiple pull requests each addressing one feature on this issue only?

[laurent22]

Yes please create a separate issue for each feature so that we can evaluate if we actually want to add it or not