Mobile: Resolves #10092: Added empty trash option on long pressing the trash folder. #10120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent22
reviewed
Mar 14, 2024
| menuItems.push({ | ||
| text: _('Empty trash'), | ||
| onPress: async () => { | ||
| Alert.alert('', _('Are you sure you want to empty the trash?\n\nAll notes and sub-notebooks within trash will be lost forever'), [ |
There was a problem hiding this comment.
Please use the exact same message as in the desktop app: This will permanently delete all items in the trash. Continue?
| onPress: async () => { | ||
| Alert.alert('', _('Are you sure you want to empty the trash?\n\nAll notes and sub-notebooks within trash will be lost forever'), [ | ||
| { | ||
| text: _('OK'), |
|
@PackElend label me please! |
|
Looks good now, thanks @Sidd-R! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #10092 partially (implemented one of the mentioned features)
On long pressing the trash folder on the side menu, a modal opens with the option of "empty trash". On pressing, another modal would open asking for final confirmation, on confirming it deletes all the folders and notes in the trash permanently.
Rationale
Called the
emptyTrashfunction fromlib/services/trash/emptyTrashon pressing the empty trash option.Demo
empty_trash_demo.mp4
Testing
Tested on Android 13 physical device.