Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight notebooks based on depth #1634

Merged
merged 3 commits into from
Jun 10, 2019
Merged

Conversation

CalebJohn
Copy link
Collaborator

I added the depth color to theme.js with the anticipation that in the future there will be more (potentially more colorfull) themes.

Example
image
image

@laurent22
Copy link
Owner

Thanks for looking into it! For info the original post is there: https://discourse.joplinapp.org/t/theme-request-subnotebook-shading/1596/4

I think the way you did it is fine but I'd limit to three levels of shading (one colour for the root, then two more for two levels down) as otherwise it might look a bit busy and we'll run out of colours anyway.

On the dark theme, I think we need to make the currently selected notebook a different colour, maybe some blueish colour so that it's still visible among the other grey colours.

@CalebJohn
Copy link
Collaborator Author

CalebJohn commented Jun 8, 2019

I've updated based on your suggestions. Take a look. It's really easy to tweak things further if necessary.
image

image

@CalebJohn
Copy link
Collaborator Author

Just a thought, should we make this toggle-able in the settings? There are always a few users that hate visual changes.

@laurent22
Copy link
Owner

Looks good, thanks @CalebJohn! For now, let's not make it toggle-able and we'll see what feedback we get.

@laurent22 laurent22 merged commit 041bdc0 into laurent22:master Jun 10, 2019
@CalebJohn CalebJohn deleted the indent-color branch July 14, 2019 19:38
@v-marinkov
Copy link

Hi, I just updated to 1.1.4 and noticed the hierarchical highlights are gone. Was this intentional and why? How can I bring them back?

@CalebJohn
Copy link
Collaborator Author

Hi @v-marinkov , The highlights were removed based on community feedback. Fortunately we left the css classes responsible for styling in so you restore the behaviour with a userchrome.css file. You can see my instructions here

@v-marinkov
Copy link

Thanks @CalebJohn, it seems like a neat solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants