Desktop, Cli: enex_to_md: support italic in span tags #1966
Conversation
|
|
||
| function isSpanStyleItalic(attributes) { | ||
| let style = attributes.style; | ||
| if (style.includes('font-style: italic;')) { |
There was a problem hiding this comment.
That seems a bit fragile - what if it is set as font-style:italic ;? Maybe spaces should be removed and the string made lowercase before testing it?
| return true; | ||
| } else { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Can be written as return style.includes('...')
|
Thanks for the PR, overall it looks good, and thanks also for adding the tests. If some tests are broken they'll need to be fixed, unless they were already broken before your changes. Could you confirm please? Another issue I guess is that the CI is not detecting that any test is failing so that needs to be fixed too, but not something you need to worry about. |
add spaces to commented out debug messages
CI wants it in there - maybe remove in another PR
|
Hi
The thing with tests not running through were my fault: I forgot to rebuild the CliClient and tests! All tests passing now. |
|
Looks good now, thanks for the PR @JOJ0! |
* Desktop, Cli: enex_to_md: support italic in span tags * Desktop, Cli: enex_to_md: readd debug message to resolve CI conflict * Desktop, Cli: enex_to_md: fix CI errors add spaces to commented out debug messages * Desktop, Cli: enex_to_md: remove redundant commented out debug message * Desktop, Cli: enex_to_md: readd redundant commented out debug message CI wants it in there - maybe remove in another PR
Hi, this should theoretically be a no-brainer. It is just an addition to the "span tags format conversion feature" you merged a couple of weeks ago (#1708). I also added a html and md pair test and it passes. Additionally I did a lot of testing with my old Evernote notes.
Anyway, I am experiencing an odd issue: Some tests don't pass and I think I didn't break them:
By any chance, are they currently broken or should they work?
Thanks