Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Make resources editable #279

Closed
5 of 8 tasks
BengaloBongali opened this issue Mar 9, 2018 · 9 comments
Closed
5 of 8 tasks

Feature Request: Make resources editable #279

BengaloBongali opened this issue Mar 9, 2018 · 9 comments
Labels
backlog We'll get to it... eventually... enhancement Feature requests and code enhancements

Comments

@BengaloBongali
Copy link

BengaloBongali commented Mar 9, 2018

Operating system

  • Windows
  • macOS
  • Linux
  • Android
  • iOS

Application

  • Desktop
  • Mobile
  • Terminal

Intro

In some cases, creating a TXT (or RTF... for the single reason of line breaks, or MD) is still the best way to take a note. That's when it needs to be editable for everybody and/or it has to be in a specific place.
My suggestion is to create a way to include such notes in Joplin.

Specification

See below

How would this work?

Let's say I create the RTF on a computer without Joplin on a USB stick. Then I put the USB stick in a computer with Joplin. Then I "Open With..." it there and choose Joplin. Joplin creates a note with the file's name as a title in its local folder and keeps the RTF's text and name in sync with it from now on. ID could be added at the end of the RTF to recognize it if the file name changes.

Is that understandable?

@BengaloBongali BengaloBongali changed the title Feature Request: Stand-Alone Clear Text Notes Feature Request: Include Stand-Alone Clear Text Notes Mar 9, 2018
@fmrtn
Copy link
Contributor

fmrtn commented Mar 9, 2018

Sounds like you're requesting an import feature.

Joplin can import from some file formats, see this https://github.com/laurent22/joplin#importing

@BengaloBongali
Copy link
Author

Only if Joplin keeps the file and the imported note synchronized as in propagates changes in the created Joplin note to the imported RTF on the USB stick and vice versa. Does it?

@laurent22
Copy link
Owner

I think what would be needed is a way to make the resources editable, which is currently not supported.

@laurent22 laurent22 changed the title Feature Request: Include Stand-Alone Clear Text Notes Feature Request: Make resources editable Mar 26, 2018
@laurent22 laurent22 added the enhancement Feature requests and code enhancements label Mar 26, 2018
@siliconninja
Copy link

Maybe a temporary directory to store files? For example, when you open the file, keep a copy of it in there temporarily (with a timestamp to differentiate it, maybe a unix millisecond timestamp), then replace the updated file. When you go back to Joplin, ask "replace the file?" or have a mark next to it indicating that it has been modified, and if you click on it, then ask that same question. If it's deleted from the note, keep the file as a backup just in case.

@laurent22
Copy link
Owner

Implementation:

  • Add an "Edit" icon when hovering over a resource link or image.
  • Open resource in editor and display dialog: "Attachment is being edited. Click 'Apply changes' when done." (Buttons: "Apply changes" / "Cancel")
  • Once resource is saved, create a new resource and replace the old resource ID with the new one in the note.
  • Need to handle case where resource is used in more than one note (Initially, maybe leave the other notes as-is, so they'll still be linked to the old resource files).

Creating a new resource every time means everything else will work the same (sync, encryption, resource indexing, etc.).

@stale
Copy link

stale bot commented Sep 22, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Sep 22, 2019
@cast-away
Copy link

not stale

@stale stale bot removed the stale An issue that hasn't been active for a while... label Sep 22, 2019
@stale
Copy link

stale bot commented Dec 21, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Dec 21, 2019
@stale
Copy link

stale bot commented Dec 28, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Dec 28, 2019
@lock lock bot locked and limited conversation to collaborators Jan 4, 2020
@laurent22 laurent22 reopened this Jan 9, 2020
@stale stale bot removed the stale An issue that hasn't been active for a while... label Jan 9, 2020
@laurent22 laurent22 added the backlog We'll get to it... eventually... label May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backlog We'll get to it... eventually... enhancement Feature requests and code enhancements
Projects
None yet
Development

No branches or pull requests

5 participants