Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joplin-renderer/assets/katex/katex.css should be updated according to KaTeX 0.12.0. #3664

Closed
spencer246 opened this issue Aug 26, 2020 · 1 comment
Labels
bug It's a bug desktop All desktop platforms high High priority issues

Comments

@spencer246
Copy link

spencer246 commented Aug 26, 2020

Environment

Joplin version: v1.0.234
Platform: Windows, but relevant to any platforms
OS specifics:

Steps to reproduce

  1. Fresh install Joplin v1.0.234 or v1.0.235.
  2. Make sure that KaTeX plugin is enabled.
  3. $a$ is rendered as an upright font, not italic.

Describe what you expected to happen

As in v1.0.233, $a$ should be properly rendered as italic.

How to fix

Since this commit, KaTeX has been upgraded from v0.11.0 to v0.12.0.

KaTeX has changed the name of a span class span.mathdefault to span.mathnormal. For example, while KaTeX v0.11.0 renders LaTeX syntax $a$ to HTML <span class="mord mathdefault">a</span>, KaTeX v0.12.0 renders $a$ to $<span class="mord mathnormal">a</span>$.

Joplin uses katex.css in joplin-renderer/assets/katex/katex.css instead of the CSS file downloaded by npm to node_modules. Therefore, joplin-renderer/assets/katex/katex.css should be manually updated to https://cdn.jsdelivr.net/npm/katex@0.12.0/dist/katex.min.css.

Logfile

@tessus
Copy link
Collaborator

tessus commented Aug 27, 2020

Yes, this is correct. I've noticed this as well, when testing/adding a newer Mermaid version.
I'm still waiting for Laurent's answer in the forum, otherwise I would have already commited the new assets (including the katex ones).

@laurent22 laurent22 added desktop All desktop platforms high High priority issues labels Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms high High priority issues
Projects
None yet
Development

No branches or pull requests

3 participants