Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing icons in AppImage build #3720

Closed
dist3r opened this issue Sep 7, 2020 · 0 comments · Fixed by #3721
Closed

Missing icons in AppImage build #3720

dist3r opened this issue Sep 7, 2020 · 0 comments · Fixed by #3721
Labels
bug It's a bug

Comments

@dist3r
Copy link
Contributor

dist3r commented Sep 7, 2020

Since version v1.0.217 (probably starting from commit 279310f) AppImage build is not compliance with AppDir specification when it comes to icons directories. Icons (there might be multiple icons with different resolutions) should be placed in directories which follows the rule: <root>/usr/share/icons/<theme>/<resolution>/apps/myapp.<ext> but instead there is only one directory: <root>/usr/share/icons/hicolor/0x0/apps/joplin.png. As there couldn't exists any picture with 0x0 resolution, tools such as AppImageLauncher fails extracting icon and Joplin gets generic picture in application launcher (e.g. in GNOME).

joplin
image

Environment

Joplin version: v1.0.217 - v1.0.242 (newest at the moment)
Platform: Linux
OS specifics: Fedora 32 with GNOME (but probably any other Linux OS)

Steps to reproduce

  1. Download affected Joplin version
  2. Install app using AppImageLauncher
  3. Start app/look for it's entry in desktop app launcher

If you want to see icon's directories structure do the following:

  1. Download affected Joplin version
  2. Extract files from AppImage file using --appimage-extract switch, e.g. ./Joplin-1.0.217.AppImage --appimage-extract
  3. Cd into squashfs-root/
  4. Examine previously described directories structure

Describe what you expected to happen

I'm providing the fix for this issue in #3721. Please review it.

Related issue

#3529
#3428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant