Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image from some websites cannot get downloaded correctly through web clipper #3984

Closed
kerhbal opened this issue Oct 25, 2020 · 4 comments
Closed
Labels
bug It's a bug clipper Anything that concerns the Web Clipper high High priority issues

Comments

@kerhbal
Copy link

kerhbal commented Oct 25, 2020

Environment

Joplin version: Joplin 1.2.6 (prod, darwin)
Platform: macOS
OS specifics: 10.15.6

Steps to reproduce

  1. open this page: https://www.macrumors.com/guide/use-apple-homepod-intercom/
  2. use clipper to clip any thing including images
  3. check the result, as shown below, the image is not downloaded, and still shows the remote link
    2020-10-25 at 15 57 27@2x

Describe what you expected to happen

download the image to local like it suppose to do

this probably has sth to do with the ?lossy part in the end of the image path, maybe clipper is only looking for images that have the path that end with proper extension?

Correction:
this may not related to text at the end of the image path, I tried this link: https://www.macrumors.com/roundup/iphone-12/

and the result is same, but this time the image path is normal, no trailing text
2020-10-25 at 23 22 07@2x

hope any one can look into this, thanks!

@kerhbal kerhbal added the bug It's a bug label Oct 25, 2020
@laurent22 laurent22 added clipper Anything that concerns the Web Clipper high High priority issues labels Oct 25, 2020
@kerhbal
Copy link
Author

kerhbal commented Oct 26, 2020

and btw I took a look, no errors in clipper log:

2020-10-25 23:15:58: "Request: GET /ping"
2020-10-25 23:15:58: "Request: GET /folders"
2020-10-25 23:15:58: "Request: GET /tags"
2020-10-25 23:16:03: "Request: POST /notes?nounce=1603682157983"
2020-10-25 23:16:03: "Request (1603682163958): Downloading images: 1"
2020-10-25 23:16:04: "Request (1603682163958): Creating resources from paths: 1"
2020-10-25 23:16:04: "Request (1603682163958): Saving note..."
2020-10-25 23:16:04: "Request (1603682163958): Created note 99f60fd56ebf494f9c9d060bce8edd0d"

@alexanderadam
Copy link

alexanderadam commented Oct 28, 2020

@kerhbal if I may give you an advice: use another extension that's storing images in base64 instead. Currently Joplin's resources won't get deleted once you delete the note (this issue is open since 2018).

I'm using Copy Selection as Markdown since I switched to Firefox again.
It has support for embedding images as base64 at the bottom of the note.

So in your example the extension is creating something like

Alongside the [HomePod mini](https://www.macrumors.com/roundup/homepod-mini/), Apple introduced a new Intercom feature that's designed to let Apple device owners communicate with one another throughout the home, sending messages to specific rooms, areas, or people.

![][img1]  
Intercom works with the [HomePod](https://www.macrumors.com/roundup/homepod/)
[]

And adds a img1 reference on the bottom of the note.

@kerhbal
Copy link
Author

kerhbal commented Oct 28, 2020

@alexanderadam yeah that's a good idea, though multiple images will result in large chunks of text data, might cause performance issue in future

@alexanderadam
Copy link

I guess this strongly depends on how the search is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug clipper Anything that concerns the Web Clipper high High priority issues
Projects
None yet
Development

No branches or pull requests

3 participants