Potential orphaned resources left on sync target on resource conflict

[roman-r-m]

It looks like whenever there's a resource conflict, Synchronizer will create a new copy of the conflicted resource and attach it to a new note:

joplin/packages/lib/models/Resource.ts

Lines 392 to 402 in f611d77

	static async createConflictResourceNote(resource: ResourceEntity) {
	const Note = this.getClass('Note');
	const conflictResource = await Resource.duplicateResource(resource.id);
	await Note.save({
	title: _('Attachment conflict: "%s"', resource.title),
	body: _('There was a [conflict](%s) on the attachment below.\n\n%s', 'https://joplinapp.org/conflict/', Resource.markdownTag(conflictResource)),
	is_conflict: 1,
	}, { changeSource: ItemChange.SOURCE_SYNC });
	}

The note is marked as conflict and so will be skipped during sync but it looks like the duplicated resource will still be uploaded to the sync target.

[laurent22]

Indeed I think the implementation is not quite right. It's also not logical to create a conflict note when it's the resource that's actually in conflict. Maybe the note should simply be added to a regular notebook, so that there's no special rules applying to it.