Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Share Notebook" with incompatible settings causes selected notebook to go to depth-0 #5421

Closed
Daeraxa opened this issue Sep 4, 2021 · 0 comments
Labels
bug It's a bug desktop All desktop platforms high High priority issues

Comments

@Daeraxa
Copy link
Collaborator

Daeraxa commented Sep 4, 2021

Attempting to use share notebook dialog with either an inappropriate sync target or (for Joplin Cloud/Server) incorrect credentials causes the selected notebook to lose its depth and parent notebook setting.
Before share button:
Capture

After:
Capture2

Environment

Joplin version: 2.4.4 pre-release & 2.3.5
Platform: Windows & macOS
OS specifics: 10 & 11.5.2

Steps to reproduce

  1. Sync target != Joplin Cloud or Joplin Server OR sync target = Joplin Cloud/Server with blank or invalid credentials
  2. Select a notebook at depth >0
  3. ctrl + shift + p to open command palette (or via toolbar)
  4. type "share" and select "Share notebook... (showShareFolderDialog)
  5. Ensure that "Synchronizing" is not shown below recipient box (wait for it to disappear if it is)
  6. Hit "share", orange banner with error "Unknown key: sync.7.username" (NextCloud selected as sync)
  7. Selected notebook has gone to depth 0 and is no longer with the original parent notebook

Describe what you expected to happen

For sync targets other than Joplin Cloud or Server - this dialog should not be accessible at all (along with Publish note)
For Joplin Cloud/Server sync targets - it should not be able to change the depth of the selected book due to credentials error

Logfile

Attached
-1630783362317.log
log.txt

@Daeraxa Daeraxa added the bug It's a bug label Sep 4, 2021
@Daeraxa Daeraxa changed the title "Share Notebook" with incompatible settings causes notebooks to go to depth-0 "Share Notebook" with incompatible settings causes selected notebook to go to depth-0 Sep 4, 2021
@laurent22 laurent22 added desktop All desktop platforms high High priority issues labels Sep 5, 2021
runchard pushed a commit to runchard/joplin that referenced this issue Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms high High priority issues
Projects
None yet
Development

No branches or pull requests

2 participants