New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App-icon missing on linux #86

Closed
yafp opened this Issue Dec 11, 2017 · 12 comments

Comments

Projects
None yet
9 participants
@yafp
Copy link

yafp commented Dec 11, 2017

20171211_144956

Operating system

  • Ubuntu Linux -

Application

  • Desktop 0.10.38

The app is not showing any specific application icon in my panel. Instead a default/generic application icon is displayed.

The android app has an app-icon, therefor i assume it is not just the fact that there is no logo designed yet.

@laurent22 laurent22 added the bug label Dec 11, 2017

@laurent22 laurent22 closed this in 931083b Dec 11, 2017

@yafp

This comment has been minimized.

Copy link

yafp commented Dec 12, 2017

This is still valid for me with 0.10.39 on Ubuntu, running gnome-shell.

If i search for joplin the blue icon is displayed in the search results, but not in the dock (using Gnome Shell extension Dash-to-Dock) itself.

@deadpyxel

This comment has been minimized.

Copy link

deadpyxel commented Feb 27, 2018

Same is happening to me, using latest (1.0.64) AppImage. The application icon is shown in the picture below:

screenshot from 2018-02-27 18-29-24

This is the application icon when I search for it:

screenshot from 2018-02-27 18-31-53

I am using:

  • Ubuntu x64 16.04.3 LTS
  • Paper icon theme
  • Gnome-shell 3.18.5

May be related to #251 or be linux-specific

@blueorignal

This comment has been minimized.

Copy link

blueorignal commented Mar 22, 2018

Hi,

Firstly, thank you for an amazing project.

You may be able to resolve this by calling "QApplication::setWindowIcon()" in Joplin.

You can see a write-up for a similar issue for another application here: https://discourse.appimage.org/t/appimage-does-not-show-icon-in-task-bar/40

There is also another approach that seems to work:

electron-userland/electron-builder#2269 (see the last post)

Hopefully either of these approaches provide a reasonably straight forward fix for the Linux icon issue.

Thanks again for the wonderful work.

Regards...

@StefanTT

This comment has been minimized.

Copy link

StefanTT commented Mar 28, 2018

If you edit the appimagekit-joplin.desktop file (located in ~/.local/share/applications) and add

StartupWMClass=Joplin

to it then the icon is displayed in Gnome3.

@deadpyxel

This comment has been minimized.

Copy link

deadpyxel commented Mar 28, 2018

@StefanTT This worked as a workaround for me.

Is there any chance that this happens due to some kind of config conflict on Gnome-Shell? My version is 3.18.5 by the way.

I wonder if with the new Ubuntu 18.04 LTS coming next month this will still happen. May be Gnome-Shell related.

@StefanTT

This comment has been minimized.

Copy link

StefanTT commented Mar 29, 2018

If I look at the generated .desktop entry and what xprop for the Joplin window outputs then I have no good idea how the window manager should get the icon for the application.

A quick test with TeamViewer - one of the apps I have installed that did not come with the distribution - showed that they do not set StartupWMClass in the desktop entry but set the window property WM_ICON_NAME.

So either the setWindowIcon() that @blueorignal suggested or my workaround should be done. I doubt that other desktop environments currently find the correct icon.

@scollovati

This comment has been minimized.

Copy link

scollovati commented Jul 25, 2018

Thank you @StefanTT !
This worked also for Linux Mint 19 with Cinnamon 3.8.8

@develar

This comment has been minimized.

Copy link

develar commented Jul 26, 2018

@laurent22 Today evening (CET) electron-builder 20.26.0 will be released — StartupWMClass will be added correctly (thanks to @StefanTT). So, you can just update electron-builder version to upcoming 20.26.0 and this issue will be fixed.

@fmmarzoa

This comment has been minimized.

Copy link

fmmarzoa commented Jul 30, 2018

@StefanTT workaround worked for me to in Ubuntu 18.04

@scollovati

This comment has been minimized.

Copy link

scollovati commented Aug 6, 2018

Actually today after reinstalling my OS (a clean install) I'm experiencing a problem with the tray icon

screenshot from 2018-08-06 09-03-08

I manually added the suggested line to the .desktop file.
Still using Linux Mint 19 with Cinnamon 3.8.8, Kernel 4.15.0-20-generic

@laurent22

This comment has been minimized.

Copy link
Owner

laurent22 commented Sep 21, 2018

Should be fixed with recently added install_ubuntu.sh script.

@laurent22 laurent22 closed this Sep 21, 2018

@grantstephens

This comment has been minimized.

Copy link

grantstephens commented Dec 2, 2018

I just experienced this with a fresh install of Joplin on a new 18.10 ubuntu install. @StefanTT 's fix worked though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment