Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on dark theme Joplin Cloud email should be white #9500

Closed
laurent22 opened this issue Dec 11, 2023 · 4 comments · Fixed by #9503
Closed

on dark theme Joplin Cloud email should be white #9500

laurent22 opened this issue Dec 11, 2023 · 4 comments · Fixed by #9503
Assignees
Labels
bug It's a bug high High priority issues mobile All mobile platforms

Comments

@laurent22
Copy link
Owner

Operating system

Android

Joplin version

2.13

Desktop version info

No response

Current behaviour

  • choose a dark theme
  • go to JC setting screen

=> The email is using a black font, but it should be white.

It needs to use the "color" property of the theme

Expected behaviour

No response

Logs

No response

@laurent22 laurent22 added bug It's a bug mobile All mobile platforms high High priority issues labels Dec 11, 2023
@pedr
Copy link
Collaborator

pedr commented Dec 12, 2023

I'm not sure how to tackle this issue yet.

I think I understand the assignment, some emails have almost unreadable content if the color scheme is set to dark:

Screenshot from 2023-12-11 21-19-37

But I have some questions

  • Are we talking only about text set to to #000 color?
  • If not, how are we going to ensure that the text is "darker" enough? Image above is an example, I think is reasonable to read, but not comfortable.
  • Some emails have background color like the image bellow, so we can't just set all font to a brighter color

image

@pedr
Copy link
Collaborator

pedr commented Dec 12, 2023

Maybe the idea is just to change the color of the content that appears in the "Forward message" header? If this is the case I imagine that we would need to have a special CSS rule for each email provider (since each one must have its own HTML structure), but I need to test some popular services to understand it better

@laurent22
Copy link
Owner Author

laurent22 commented Dec 12, 2023

Sorry I was on mobile when I wrote this bug report and it's not very clear.

I mean, in the mobile app, open the configuration screen, and go to to the "Joplin Cloud" section. There you have your email-to-note email address that's displayed. It's always in black, whether the current time is light or dark, which means it's not readable in dark theme.

The other issue you raised is indeed also something we'll need to deal with though, but it's more a general issue about how the desktop app displays HTML-based notes.

@pedr
Copy link
Collaborator

pedr commented Dec 12, 2023

Ah ok, that makes sense. Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug high High priority issues mobile All mobile platforms
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants