Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Fixes #9500: Fix font for the inbox email address not using the theme color #9503

Merged
merged 1 commit into from Dec 13, 2023

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Dec 12, 2023

Fixes #9500

Testing

  • Connect to Joplin Cloud
  • Change themes
  • Access Joplin Cloud settings screen
  • Inbox email/Email to Note value should change color according to theme scheme

Screenshot from 2023-12-12 10-44-11
Screenshot from 2023-12-12 10-44-36
Screenshot from 2023-12-12 10-45-02
Screenshot from 2023-12-12 10-45-44

@pedr pedr added bug It's a bug mobile All mobile platforms labels Dec 12, 2023
@pedr pedr requested a review from laurent22 December 12, 2023 13:55
@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Dec 12, 2023

Thank you for working on this!

The failing tests seem to be Playwright test timeouts (related to #9497). If this keeps happening, it should be possible to record video in CI and upload the video to see what's happening (hopefully we don't have to do this).

I've re-run CI.

@laurent22
Copy link
Owner

If this keeps happening, it should be possible to record video in CI and upload the video to see what's happening

Let's see if we keep having errors after the timeout increase. If so, we can indeed try this

@laurent22 laurent22 merged commit 6d6f9b3 into laurent22:dev Dec 13, 2023
10 checks passed
@pedr pedr deleted the etn-mobile-fix-text-color branch December 13, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug mobile All mobile platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on dark theme Joplin Cloud email should be white
3 participants