Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: "Save mermaid" button adds extra space above diagrams when invisible #9829

Closed
personalizedrefrigerator opened this issue Feb 2, 2024 · 0 comments · Fixed by #9830
Assignees
Labels
bug It's a bug

Comments

@personalizedrefrigerator
Copy link
Collaborator

Operating system

Linux

Joplin version

2.13.15

Desktop version info

Joplin 2.13.15 (prod, linux)

Client ID: 24b2a961cccf40fe8448cdc0930b6fce
Sync Version: 3
Profile Version: 44
Keychain Supported: No

Revision: 7d2c1c0

Freehand Drawing: 2.7.1
RevealJS Integration: 0.7.0
Simple Backup: 1.3.6
Work tracker: 0.0.1

Current behaviour

Currently, the "save mermaid diagram" button adds about 30px of additional space above mermaid diagrams in the viewer:
screenshot, space allocated for save button shown

This causes diagrams to have more space above than below:
screenshot: extra space above diagram

Expected behaviour

Ideally, diagrams should be vertically centered (the save button should overlay the diagram).

Logs

No response

@personalizedrefrigerator personalizedrefrigerator added the bug It's a bug label Feb 2, 2024
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Feb 2, 2024
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Feb 2, 2024
laurent22 pushed a commit that referenced this issue Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug
Projects
None yet
1 participant