Desktop: Fixes #9932: Fix only one CodeMirror 6 content script loaded per plugin #9934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, if a plugin registered two CodeMirror content scripts, the IDs used for both content scripts would be the same. This pull request causes the CodeMirror 6 plugin loader to consider both
contentScript.pluginId
andcontentScript.contentScriptId
when generating internal IDs.Fixes #9932.
Testing