Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta markdown editor: Support Ctrl+Enter keyboard shortcut (Cmd+Enter on MacOS) #9980

Closed
personalizedrefrigerator opened this issue Feb 22, 2024 · 2 comments · Fixed by #10003
Labels
editor enhancement Feature requests and code enhancements good first issue medium Medium priority issues

Comments

@personalizedrefrigerator
Copy link
Collaborator

Operating system

Linux

Joplin version

2.14

Desktop version info

No response

Current behaviour

Currently, pressing Ctrl-Enter (Cmd+Enter on MacOS) in the beta and legacy markdown editors does nothing. In VSCode and with the default CodeMirror setup, it inserts a new line below the current.

Expected behaviour

Pressing Ctrl-Enter should have behavior consistent with VSCode and the CodeMirror 6 defaults.

Logs

No response

@personalizedrefrigerator personalizedrefrigerator added bug It's a bug enhancement Feature requests and code enhancements backlog We'll get to it... eventually... editor and removed bug It's a bug labels Feb 22, 2024
@personalizedrefrigerator personalizedrefrigerator added medium Medium priority issues and removed backlog We'll get to it... eventually... labels Feb 23, 2024
@njmulsqb
Copy link
Contributor

I am trying to work on it but need a bit assistance in finding where to add the changes. I found this article https://www.electronjs.org/docs/latest/tutorial/keyboard-shortcuts that mentions adding the shortcuts in Electron JS using accelerator but I want to know where should I implement these changes as we have multiple directories in note body i.e. CodeMirror, PlainEditor, TinyMCE.

If someone can point me to the relevant code it'll help a lot.

@roman-r-m
Copy link
Collaborator

I don't think this has anything to do with electron shortcuts. It should be specific to CodeMirror (version 6, since it mentions beta editor, I believe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor enhancement Feature requests and code enhancements good first issue medium Medium priority issues
Projects
None yet
4 participants