All: Fix packages\lib\fsDriver.test.ts test file on Windows
#10053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
laurent22
reviewed
Mar 5, 2024
packages/lib/fsDriver.test.ts
Outdated
Comment on lines
6
to
8
| const filePath = __filename; | ||
| const parsedPath = parse(filePath); | ||
| const partitionLetter = parsedPath.root[0].toLowerCase(); |
There was a problem hiding this comment.
How about justconst partitionLetter = __filename[0]?
There was a problem hiding this comment.
And call it windowsPartitionLetter to make it clearer what it is about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug details
Bug fix was suggested in this forum post: https://discourse.joplinapp.org/t/should-i-test-the-whole-repo-when-editing-one-package-some-tests-already-failing/36385/6
Not aware of any open issues for the bug.
Fix details
Fixes
packages\lib\fsDriver.test.tson Windows by replacing the static partition letterc:and instead dynamically finding out the correct partition letter for the project, by examining the test file's path.Will depend on the CI to test it on Linux
GSoC-24 Details
My introduction on forums link: https://discourse.joplinapp.org/t/introducing-nightknight/36296/2
@PackElend label me please