Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #10062: Fix pasting images from the rich text editor into the rich text editor #10064

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

Fixes #10062 by replacing image URLs before cache breakers (?t=someidheres) are added.

Note

This pull request targets version 2.14 because this seems to be a regression. (Comparing with version 2.13.8).

Testing

  1. Create a note with images in the rich text editor
  2. Select everything
  3. Paste it
  4. Switch to the markdown editor
  5. Switch back to the rich text editor
  6. Verify that images are still visible

This has been tested successfully on Ubuntu 23.10.

@laurent22
Copy link
Owner

Looks good, thank you!

@laurent22 laurent22 merged commit 406c778 into laurent22:release-2.14 Mar 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants