Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #10082: Fix text not shown in plugin message boxes #10084

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Mar 7, 2024

Summary

Fixes an issue where the default message in showMessageBox's options would override the message parameter, resulting in an empty alert dialog.

Fixes #10082.

Testing

This has been manually tested by:

  1. Right-click deleting a notebook
  2. Verifying that the "Move notebook ... to the trash" dialog appears and can be canceled.
  3. Running await joplin.views.dialogs.showMessageBox("Foo") from the development tools for a development plugin.
  4. Verifying that the message box that appears has text.

@personalizedrefrigerator personalizedrefrigerator changed the title Desktop: Fixes #10080: Fix plugin dialogs are empty Desktop: Fixes #10080: Fix text not shown in plugin message boxes Mar 7, 2024
@personalizedrefrigerator personalizedrefrigerator changed the title Desktop: Fixes #10080: Fix text not shown in plugin message boxes Desktop: Fixes #10082: Fix text not shown in plugin message boxes Mar 7, 2024
@laurent22 laurent22 merged commit bae16f7 into laurent22:dev Mar 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop: Plugin showMessageBox dialogs are empty
2 participants