Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #10067: Fix dragging notebooks to the toplevel notebook #10302

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

Fixes #10067.

Testing plan

This pull request includes automated tests. However, it has also been tested manually by:

  1. Dragging a notebook to the trash.
    • Verifying that it is indeed trashed.
  2. Dragging the same notebook to the "NOTEBOOKS" header
    • Verifying that the notebook is moved out of the trash.
  3. Drag the notebook to another notebook.
    • Verify that it is made a subnotebook of the other.
  4. Drag the notebook back to the "NOTEBOOKS" header.
  5. Verify that it is converted to a toplevel notebook.

This has been tested successfully on Ubuntu 23.10.

@laurent22 laurent22 merged commit 385fe7b into laurent22:dev Apr 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop: Cannot move subfolder to root with drag-and-drop
2 participants