Mobile: Fixes #10313: Fix error on retry or ignore attachment too large error #10314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t too large to download error
Comment on lines
+112
to
+125
| const createAttachmentDownloadError = async () => { | ||
| await switchClient(2); | ||
|
|
||
| const note1 = await Note.save({ title: 'note' }); | ||
| await shim.attachFileToNote(note1, `${supportDir}/photo.jpg`); | ||
| await synchronizerStart(); | ||
|
|
||
| await switchClient(1); | ||
|
|
||
| const previousMax = synchronizer().maxResourceSize_; | ||
| synchronizer().maxResourceSize_ = 1; | ||
| await synchronizerStart(); | ||
| synchronizer().maxResourceSize_ = previousMax; | ||
| }; |
There was a problem hiding this comment.
Currently, this logic is roughly copied from Synchronizer.resources.test.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an error caused by
ReportServicereferencing anundefinedproperty inretryHandlerandignoreHandler.Fixes #10313.
Note
This pull request is marked as
Mobile:becausemaxResourceSizeisInfinityon desktop and CLI.Testing plan
This pull request has an automated test. It has also been tested manually by 1) clicking "ignore" by an error for an item that failed to download and 2) verifying that the item is moved to the "ignored" section.