Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: Plugins: Show information page before enabling plugin support #10348

Merged
merged 11 commits into from May 2, 2024
Merged

Mobile: Plugins: Show information page before enabling plugin support #10348

merged 11 commits into from May 2, 2024

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Apr 22, 2024 •
edited

Summary

This PR shows an information page before plugin support is enabled.

Screenshots

screenshot: settings section: Plugins: What are plugins? \\ Plugins extend Joplin with features that are not present by default. Plugins can extend Joplin's editor, viewer, and more. ((continued))screenshot: settings section: Scrolled down: Plugins: Like any software you install, plugins can potentiallhy cause security issues or data loss. Newline. Here's what we do to make plugins safer. Card: Icon: Crown: Recommended plugins: Body: We mark plugins developed by trusted Joplin community members as quote recommended unquote. Card: Icon: Branch: Open Souruce: Most plugins have source code freely available for review on the plugin website. Card: Report system: We have a system for reporting and removing problematic plugins // learn more button // Enable plugin support button

Testing plan

  1. Navigate to settings > plugins.
  2. Verify that the plugin about screen is shown.
  3. Click "Learn more".
  4. Verify that the plugin help page is opened.
  5. Go back to Joplin.
  6. Click "Enable plugin support".
  7. Verify that the existing plugin screen is shown and all plugins are loaded (if any were installed before testing the PR).
  8. Install the note tabs plugin.
  9. Verify that the "show plugin panels" icon is visible in the toolbar.
  10. Click "show advanced settings" and use the "enable plugin support" toggle to disable plugin support.
  11. Verify that the "show plugin panels" icon disappears.

This has been tested successfully on an Android 10 emulator.

laurent22
laurent22 reviewed Apr 25, 2024
View reviewed changes
packages/app-mobile/components/screens/ConfigScreen/plugins/EnablePluginSupportPage.tsx Outdated
return (
<View>
<View style={styles.descriptionContainer}>
<Text>{_('Like any software you install, plugins can potentially cause security issues or data loss.')}</Text>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start by describing what plugins are and why it might be interesting to enable the feature?

@personalizedrefrigerator personalizedrefrigerator mentioned this pull request Apr 29, 2024
Merged
@laurent22 laurent22 merged commit 4056fc2 into laurent22:dev May 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurent22 laurent22 laurent22 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@personalizedrefrigerator @laurent22