Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Fixes #10352: Fix cursor jumps before end of word while typing -- update @codemirror/view to v6.26.3 #10353

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Apr 22, 2024

Summary

Updates @codemirror/view to v6.26.3 from v6.26.0. This applies a fix for an upstream issue that could cause the cursor position to be incorrect while typing.

This should fix #10352.

Note: I have been unable to reproduce this issue locally.

Manual testing

The CodeMirror 6-based editor has automated tests. Additionally, on an Android 10 emulator, I have verified that:

  • Auto-indentation within a JavaScript code block still works.

    Code block:

    ```js
    function foo() {
       ;
    }
    ```
    

    Testing by pressing enter after moving the cursor to the ;.

  • Checklist continuation still works.

  • Searching using the search button still works.

@personalizedrefrigerator personalizedrefrigerator changed the title Mobile: Fixes #10352: Update @codemirror/view Android: Fixes #10352: Fix cursor moves while typing -- update @codemirror/view to v6.26.3 Apr 22, 2024
@personalizedrefrigerator personalizedrefrigerator changed the title Android: Fixes #10352: Fix cursor moves while typing -- update @codemirror/view to v6.26.3 Android: Fixes #10352: Fix cursor jumps before end of word while typing -- update @codemirror/view to v6.26.3 Apr 22, 2024
@laurent22 laurent22 merged commit 8984243 into laurent22:dev Apr 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing messed up in latest Android version 3.0.2
2 participants