Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Improve dialog styling on large and notched screens #10470

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented May 24, 2024

Summary

This pull request includes a subset of the changes from #10465. It:

  1. Prevents dialogs from being covered by the device notch when in landscape mode.
  2. Vertically centers the plugin panels dialog and plugin info dialogs on large screens.
  3. Dims the background of plugin panels and info dialogs.

Screenshots

Small screen with notch

image

image

Show screenshots from before

image

Large screen

image

Show screenshots from before

image

Testing plan

  1. Start with a device in landscape mode.
  2. Open the note editor.
  3. Add a link using the link dialog.
    • Verify that the link dialog does not overlap the notch (if present).
  4. Add a tag using the tag dialog.
    • Verify that the tag dialog does not overlap the notch (if present).
  5. Open the plugin panels dialog.
    • Verify that content outside the panels dialog is faded.
    • Verify that the dialog does not overlap the device notch (if present).
  6. Close the plugin panels dialog.
  7. Repeat steps 2-7 for the same device in portrait mode.

This has been tested on an iOS 17.4 simulator (with a notch) and an Android 14 device (no notch).

@personalizedrefrigerator personalizedrefrigerator added mobile All mobile platforms plugins Anything related to Joplin's plugin system labels May 24, 2024
@laurent22 laurent22 merged commit 28f3d53 into laurent22:dev May 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile All mobile platforms plugins Anything related to Joplin's plugin system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants