Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: add alternate codeblock shortcut (Ctrl+') #1923

Closed

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Oct 1, 2019

Some keybord layouts have an issue with the backtick character.
Even setting no dead keys for those layouts may not work.

See also this topic on the forum.

Update: I could only find a way to do that by creating a second invisible menu item. And this won’t trigger on macOS before Electron 6. But as mentioned before, on mcOS it’s not necessary anyway, because there’s a workaround by redefining the shortcut via the OS (System Preferences -> Keyboard -> Shortcuts -> App Shortcuts ).

Someone has to test this, because I don’t have Windows or Linux with a DE.


I believe something is wrong with the CI pipeline.

Some keybord layouts have an issue with the backtick character.
Even setting no dead keys for those layouts may not work.
@tessus tessus added the desktop All desktop platforms label Oct 1, 2019
@laurent22
Copy link
Owner

laurent22 commented Oct 1, 2019

I think we just need to re-think the keyboard shortcuts as a whole.

+L was taken for the layout, so we had to use +K for links. Then +K was taken so we had to use +backtick for code. And now we're adding more hacks to the codebase because of this.

For now I won't merge it unfortunately, and later we'll see about proper improvements to the shortcuts.

@laurent22 laurent22 closed this Oct 1, 2019
@tessus
Copy link
Collaborator Author

tessus commented Oct 1, 2019

@laurent22 I'm sorry, but I have to disagree with you there. At least partly.

+L was taken for the layout, so we had to use +K for links. Then +K was taken so we had to use +backtick for code.

I don't think so. +K is always used for links, see github, discourse, ... It's practically a standard to use +K for links. (I guess L was taken and people decided to just use the last character of the word instead.)
Even, if we had +K available, would you have really used it for code? I certainly wouldn't have, because too many people would have created code blocks instead of links. Also why +K for code? Like k in kode? I'm just curious.

The +backtick was not a hack, at least not for me. The only hack would be to add an alternate shortcut because of non-English keyboard layouts.

While I do underatand the wish to add customizable shortcuts, I would not change the current keyboard shortcuts. This is like changing the default values to something else.

@tessus tessus deleted the alternate-code-block-shortcut branch November 6, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop All desktop platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants