Desktop: Display selected tags under a note title #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abijeet
commented
Dec 22, 2019
| action.type === 'NOTE_SELECT_TOGGLE') { | ||
| let noteTags = []; | ||
| // We don't need to show tags unless only one note is selected. | ||
| if (newState.selectedNoteIds && newState.selectedNoteIds.length === 1) { |
There was a problem hiding this comment.
@laurent22 - I've made this fairly restrictive since we only display note contents when a single tag is selected.
Follow up to #893 Now using middleware to set the tags when a note is selected This avoids the ugly code in the NoteTextComponent where we determine if tags are to be fetched, identify if they have been modified, fetch them and then dispatch an action to update the store which might again re-render the component. Also implements style related fixes from #1000 Signed-off-by: Abijeet <abijeetpatro@gmail.com> Fixes: #469
|
Ping @laurent22 |
Abijeet
changed the title
|
@Abijeet, sorry for the late reply, I've only just started to go through the open pull requests. Couldn't find any issue with your changes, it all looks very solid, so we can merge. Thanks for this feature, I think many people will like that! |
No problem. Just wanted to ensure that this did not miss your radar considering you probably get 10's of notification daily. Happy new year btw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #893
Now using middleware to set the tags when a note is selected
This avoids the ugly code in the NoteTextComponent where we determine
if tags are to be fetched, identify if they have been modified, fetch
them and then dispatch an action to update the store which might
again re-render the component.
Also implements style related fixes from #1000
Fixes: #469
Tests