Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shortcut to duplicate line to CodeMirror #4869

Closed
wants to merge 2 commits into from
Closed

add shortcut to duplicate line to CodeMirror #4869

wants to merge 2 commits into from

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Apr 20, 2021 •
edited

@tessus tessus added the editor label Apr 20, 2021
@CalebJohn
Copy link
Collaborator

I think duplicateLine should probably be added as a joplin command, that way users will be able to remap it.
I've made an example of what it takes to add a new command via the command system. You can see it here

@tessus
Copy link
Collaborator Author

tessus commented Apr 21, 2021

Sure, sound like a good idea. You can close my PR and create a new one, since you already wrote the code....

@tessus
Copy link
Collaborator Author

tessus commented Apr 21, 2021

@CalebJohn What do you want to do?

@CalebJohn
Copy link
Collaborator

@tessus right, sorry about the delay. I'll open a PR.

@CalebJohn CalebJohn closed this Apr 21, 2021
@CalebJohn CalebJohn mentioned this pull request Apr 21, 2021
Merged
@tessus
Copy link
Collaborator Author

tessus commented Apr 21, 2021

No worries, just wanted to know if I can do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tessus @CalebJohn