Desktop: Resolves #6254: Open details tag on Pdf Export #6265
Conversation
| @@ -0,0 +1,17 @@ | |||
| const preprocessor = { | |||
| // Open the details tag | |||
| openDetailsTags: (htmlData: string): string => { | |||
There was a problem hiding this comment.
What if I have the details tag inside a markdown code block? Like this
```
<details>
...
</details>
```
There was a problem hiding this comment.
It won't add if it is under backticks
|
I feel there are too many issues in this pull request and it would take too much work to get it done. For example it should parse the HTML properly, and not use a regex (how do you handle tags over multiple lines, or with comments in between, or mixed case, etc). For that reason I'd prefer to close this pull request. By the way in the pull request guidelines you'll see we have this rule of one pull request per participant. You already have 5 so you don't need to do more. |
|
Yes, I should have use an HTML parser instead of the regex
Sorry, I didn't get that, I have no PR open right now, so can I work on other issues. |
Fixes #6254
Add open attribute in details tags while exporting in pdf form.