Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All: Resolves #6266: Filter keywords casesensetive #6267

Merged
merged 5 commits into from Mar 15, 2022

Conversation

JackGruber
Copy link
Contributor

Fixes #6266 that only lowercase keywords work in the search filters.

I wanted also convert the SearchFilter.test.js to TypeScript, but unfortunately I can't manage the following line.
Parameter 'a' implicitly has an 'any' type.ts(7006) const ids = (array) => array.map(a => a.id);

@laurent22
Copy link
Owner

I can't manage the following line.
Parameter 'a' implicitly has an 'any' type.ts(7006) const ids = (array) => array.map(a => a.id);

It would be fine to leave it as "any" in this case, it's still better than having a JS file. The proper way would be to define the interface that this function accepts, which is something generic like interface ObjectWithId { id: any; } ("id" can also be "any" because it's a generic function that could work with any type of ID). Then const ids = (array:ObjectWithId[]) ....

@JackGruber
Copy link
Contributor Author

Tanks for the hint

@laurent22
Copy link
Owner

Looks good, thanks for the fix @JackGruber!

@laurent22 laurent22 merged commit 3f73293 into laurent22:dev Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter keywords casesensetive
2 participants