New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Fixes #8530: Rich text editor: Use fewer
s in markdown while still preserving initial paragraph indentation
#8529
Merged
laurent22
merged 7 commits into
laurent22:dev
from
personalizedrefrigerator:pr/revert-nbsp-changes
Jul 23, 2023
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
eaa9b2e
Turndown: Revert to using unicode nonbreaking spaces
personalizedrefrigerator fff937b
Update tests
personalizedrefrigerator 78dcf6e
Completely remove now-unused function added to turndown when merging …
personalizedrefrigerator e0fc40d
Restore deleted function -- it will be necessary for leading spaces
personalizedrefrigerator eec9296
Only replace first nonbreaking space in a paragraph.
personalizedrefrigerator ca0f02e
Remove invalid import
personalizedrefrigerator c5eb407
Remove usage of invalid import
personalizedrefrigerator File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
**A test...** Test | ||
**A test...** Test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaceNonbreakingSpaces
was not present in upstream turndown and was added by #8468. It is no longer used and has thus been removed.