Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Resolves #8493: Link to FAQ when encryption password may have been reset by an update #8667

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Aug 14, 2023

Summary

This pull request adds a link to the relevant section of the FAQ when the user is on an ARM64 Mac with a missing master key password.

Resolves #8493.

Testing

  1. Modify MissingPasswordHelpLink.tsx such that the help link displays on the current system (e.g. comment out process.arch === 'arm64' if on an x86_64 Mac).
  2. Launch Joplin and clear the encryption password.
  3. Click on the help link.

Screenshot

Screenshot: Help: Missing password link in encryption settings

Notes

There may be a better solution -- the link is currently shown on any MacOS/ARM64 system with an empty encryption password. Additionally, it adds to an already large amount of text. An alternative might be to

  1. make the link appear on all systems and link to the encryption setup documentation, and,
  2. link the encryption setup documentation to the relevant portion of the FAQ.

@personalizedrefrigerator personalizedrefrigerator marked this pull request as ready for review August 15, 2023 19:15
@personalizedrefrigerator personalizedrefrigerator changed the base branch from dev to release-2.12 August 15, 2023 19:16
@personalizedrefrigerator personalizedrefrigerator force-pushed the pr/add-macos-help-link-if-missing-encryption-password branch from c3e2d89 to 9bde9ec Compare August 15, 2023 19:18
@laurent22
Copy link
Owner

There may be a better solution -- the link is currently shown on any MacOS/ARM64 system with an empty encryption password. Additionally, it adds to an already large amount of text. An alternative might be to

How about making it time limited - you display the message for two months from the release date (till 1 Nov), then you display the default?

@personalizedrefrigerator personalizedrefrigerator force-pushed the pr/add-macos-help-link-if-missing-encryption-password branch from 400358c to ca5b55a Compare August 18, 2023 19:12
@laurent22 laurent22 merged commit 3778f19 into laurent22:release-2.12 Aug 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify error message when master password cannot be found in keychain
2 participants