Desktop: Fixes #8726 - Rich Text editor toolbar doesn't show all buttons even when there's enough space #8754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed 2 CSS properties that was setting the width and min-width of the toolbar's button and it solved the problem. I'll try to explain what was happening. The default button's width is 35px and it was setting to 26px, I believe that TinyMCE was doing the calculation based on 35px and not 26px, so is like TinyMCE "thought" that the buttons were occupayin more space than they actually were.
To set the width of the toolbar's buttons correctly I think we need to Create a skin for TinyMCE. I prefer to finish this PR like this and if we decide to create a skin to change the width of the buttons we can open another PR.