Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fix #9779: Linux: Fix bundled Simple Backup can't create 7zip archives #9780

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jan 25, 2024

Summary

Fixes #9779 by moving the 7Zip binary to the cache directory before running it on non-Mac/non-Windows systems.

Testing

  1. Build Joplin (yarn dist --publish=never)
  2. Run the just-built version of Joplin
  3. Configure Simple Backup to create 7Zip archives
  4. Create a backup
  5. Verify that .7z files are created in the profile directory.

This has been tested successfully on Ubuntu 23.10.

To-do

  • Test on Mac
  • Test on Windows
    • This may take a while (I need to create a new Windows VM). Additionally, on Windows, the behavior should be the same as on Mac.

@laurent22 laurent22 merged commit da4d57c into laurent22:dev Jan 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 2.14: Bundled Simple Backup fails to create 7Zip archives on some Linux systems
2 participants