MacOS: Resolves #9488: Add "Window" menu to toolbar on MacOS #9859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
personalizedrefrigerator
changed the title
laurent22
reviewed
Feb 5, 2024
packages/app-desktop/gui/MenuBar.tsx
Outdated
| @@ -851,7 +869,7 @@ function useMenu(props: Props) { | |||
| accelerator: keymapService.getAccelerator('help'), | |||
| click() { void bridge().openExternal('https://joplinapp.org'); }, | |||
| }, { | |||
| label: _('Joplin Forum'), | |||
| label: _('Joplin Forumm'), | |||
There was a problem hiding this comment.
A typo here, otherwise I think we can merge
| @@ -20,6 +20,8 @@ const getLabel = (commandName: string): string => { | |||
| return _('Website and documentation'); | |||
| case 'hideApp': | |||
| return _('Hide Joplin'); | |||
| case 'minimizeWindow': | |||
| return _('Minimize'); | |||
There was a problem hiding this comment.
The text should be "Minimise" (the command name however should indeed use US English)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves #9488 by allowing the MacOS "Window" menu to be shown. This pull request also allows configuring "minimizeWindow" through Joplin's keyboard shortcut settings.
Other apps I've looked at (VSCode, Firefox, Finder, Calculator, Safari, Terminal) also show the "Window" menu. Additionally, it's mentioned in Apple's Human Interface Guidelines.
Screenshot
Notes
To-do
Testing
MacOS:
This has been successfully tested on MacOS Sonoma.
Linux:
This has been tested successfully on Ubuntu 23.10.