Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #9855: Allow using editor commands in the command palette #9861

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

Enables editor commands when the command palette or goto anything are visible. Fixes #9855.

Warning

At present, this pull request causes a regression: While gotoAnythingVisible, editor keyboard shortcuts (ctrl-i, ctrl-b, ...) can be used to run editor commands.

Testing plan

  1. Open Joplin
  2. Switch to the markdown editor
  3. Select text
  4. Open the command palette
  5. Run textBold
  6. Verify that the selected text has been bolded
  7. Repeat steps 4-6 for editor.indentMore and undo
  8. Switch to the rich text editor
  9. Select text
  10. Run textBold from the command palette
  11. Verify that the selection has been bolded
  12. Open the "tags" dialog
  13. Try to bold/unbold the selection with ctrl-b
  14. Verify that the selection's formatting doesn't change.

This has been tested successfully on Ubuntu 23.10.

@laurent22 laurent22 merged commit 8b9ce9e into laurent22:dev Feb 6, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression in command palette: text commands not shown
2 participants