Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Fixes #7974: Fix regression: Crash when opening appearance/sync settings on some devices #9864

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

Adjusts the patch for #7974 such that it applies to all versions of @react-native-community/slider.

Fixes #7974.

Testing

  1. Set the lower limit for sliders in settings to be greater than the upper limit (simulates the issue that led to the crash):
diff --git a/packages/app-mobile/components/screens/ConfigScreen/SettingComponent.tsx b/packages/app-mobile/components/screens/ConfigScreen/SettingComponent.tsx
index 87b381d71..9cbb4809f 100644
--- a/packages/app-mobile/components/screens/ConfigScreen/SettingComponent.tsx
+++ b/packages/app-mobile/components/screens/ConfigScreen/SettingComponent.tsx
@@ -105,6 +105,8 @@ const SettingComponent: React.FunctionComponent<Props> = props => {
 						step={md.step}
 						minimumValue={minimum}
 						maximumValue={maximum}
+						lowerLimit={4}
+						upperLimit={1}
 						value={props.value}
 						onValueChange={newValue => void props.updateSettingValue(props.settingId, newValue)}
 					/>
  1. Re-run yarn install from the root directory of the repository
  2. Rebuild and re-run the Android app
  3. Verify that the application doesn't crash upon opening appearance settings and that the "font size" slider can be used.

This has been tested successfully on Android 7.

@laurent22 laurent22 merged commit a364f66 into laurent22:dev Feb 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Version 2.10.8-2.12.3 crashes on Configuration button click. Partially fixed in version 2.13.10.
2 participants