Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #9891: Don't rerender markdown notes when the note preview pane is hidden #9901

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Feb 8, 2024

Summary

Avoids rerendering when the markdown preview pane is hidden.

Fixes #9891.

Testing

  1. Enable the CodeMirror 5 markdown editor
  2. Paste ten copies of the Project Gutenberg Ebook of Frankenstein into a note.
  3. Hide the markdown preview pane
  4. Add text near the end of the document. Verify that the UI doesn't freeze after a brief pause in typing.
    • Without this pull request, on my computer, the UI freezes for a few seconds after a pause in typing. When this happens, if I try to continue typing, nothing new shows up until the UI unfreezes.
  5. Repeat steps 1-4 for the CodeMirror 6 markdown editor.

This has been tested successfully on Ubuntu 23.10.

@laurent22 laurent22 merged commit 802f6c4 into laurent22:dev Feb 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown editor: Note rerenders even when the markdown preview pane is hidden
2 participants