Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Firefox Console Redirector.exe #12

Closed
wants to merge 12 commits into from
Closed

Added Firefox Console Redirector.exe #12

wants to merge 12 commits into from

Conversation

matthewkastor
Copy link
Contributor

Added superfluous looking check on SLIMERJSLAUNCHER. It fixes an issue
where the batch file bails out while checking whether or not the path
exists.

Firefox Console Redirector should behave exactly as we intended the bat
file to behave except, the console redirection actually gets the output
back to the console on windows. There aren't any temp files involved, it
just works. I've put the help menu in and as far as I know it can
replace the batch file. All we really need is for a few people to test
it out. I compiled it for "Any CPU" so it should work on 32 and 64 bit
systems. One thing I don't like is that I couldn't find an asynchronous stream reader that would update the console on any input. As it stands, the best I found so far is the async. line reader. The redirected sterr and stdout from firefox show up in the console after every line break. So, if you test it out using the dump function from the firebug, jsconsole, scratchpad, etc. You'll have to add \r, \n, or \r\n to the end of your dump in order to flush it to the console immediately. I don't know if that's the same behavior as on other platforms.

matthewkastor and others added 9 commits February 6, 2013 15:24
Still gives error in phantom.jsm line 34
Conflicts:
	API.md
	bin/slimerjs.bat

merge upstream master
Added superfluous looking check on SLIMERJSLAUNCHER. It fixes an issue
where the batch file bails out while checking whether or not the path
exists.

Firefox Console Redirector should behave exactly as we intended the bat
file to behave except the console redirection actually gets the output
back to the console on windows. There aren't any temp files involved, it
just works. I've put the help menu in and as far as I know it can
replace the batch file. All we really need is for a few people to test
it out. I compiled it for "Any CPU" so it should work on 32 and 64 bit
systems.
@matthewkastor matthewkastor mentioned this pull request Feb 9, 2013
Cleaned up the code that goes into making the executable for launching
SlimerJs. Added a couple switches: /initialtests and /maintests that
will run the initial-tests.js and main-tests.js. I've documented them in
the console help.

I ran the tests and copied the results into two text files. Windows
fails a couple of the tests in main-tests.js. I couldn't read the
results because of the shellcodes. They don't colorize the results on
Windows, they just fill the screen with gibberish. I added a copy of the
Wikipedia page that gives way too much information about the
incompatibility of color codes in terminals. It sounds even worse than
the inconsistencies between web browsers today.

I deleted the batch file because it's useless now. I deleted Firefox
Console Redirector.exe because SlimerJsRun.exe replaces it.

I added GeckoLib.dll and Redirector.dll because SlimerJsRun.exe requires
them. Redirector is a generic stderr stdout redirector for arbitrary
processes. GeckoLib extends Redirector and adds some helper functions to
make it easy to use with XULRunner, Firefox, Thunderbird,
[conkeror](http://conkeror.org/), etc. etc. SlimerJsRun extends GeckoLib
with a few functions specific to this project.

I turned off the colors in Jasmine's output.
@matthewkastor
Copy link
Contributor Author

This pull request would close both #7 and #1
It also makes the output of main-tests.js legible on all systems.
It also adds switches to run initial-tests.js and main-tests.js: /initialtests and /maintests.

@laurentj
Copy link
Owner

Why is there this test/testResults directory? I think it is useless.

@matthewkastor
Copy link
Contributor Author

So is writing an application to redirect stupid console messages back to the original console instead of simply waiting for the user to acknowledge they've read the error before exiting the application.

But... that's exactly what you wanted to do. Now I've made this stupid application, handed it to you, and all you have to say in response is that you don't like the file I left you that shows three failing tests.

Well, you're welcome.

@laurentj
Copy link
Owner

Why did you close this pull request ?

Did I say I don't want your contribution ? I just asked you a question about this testResults directory. Ok, it shows results, but it is totally useless in the repository. just remove it.

@matthewkastor
Copy link
Contributor Author

From the desk of Matthew Kastor

On this glorious Thursday, February 21, 2013
Summary

So... you were that rude on accident?
Message

I closed it because I wanted to delete my fork of slimerjs. I've got a repo
for a generic redirector application for windows that includes the slimerjs
redirector as a sub project in the visual studio solution.

When I submitted the pull request I did not expect you to do cartwheels and
send me emails covered in glitter but I also didn't expect you to
completely disregard the enormous amount of time and effort I put into
coming up with a solution to this intentionally ignored bug in Gecko based
applications. That is exactly what you did though, you completely ignored
my awesome hackery that does absolutely nothing for any of my personal
projects and only benefits you directly. Then you proceeded to whine that I
had included relevant test results, again for your benefit, related to the
performance of your application on windows systems. That was rude really,
and it let me know to focus my efforts elsewhere.

If you want to use the redirector you can find it at
https://github.com/matthewkastor/Redirector build the SlimerJsRun project
and you'll have it. The help file is an included resource in that project.
Just edit the resource to change the help text.

Relevant bugzilla links to command line retardation:
No command line parameters -help (e.g., for langpacks,
profiles)https://bugzilla.mozilla.org/show_bug.cgi?id=355889#c20
[FEATURE] Add command line option to cause Windows console output to
appear.https://bugzilla.mozilla.org/show_bug.cgi?id=26103
Launching Firefox 15 from DOS command prompt/batch file closing
problemhttps://bugzilla.mozilla.org/show_bug.cgi?id=787313
-no-remote browser accepts remote
commandshttps://bugzilla.mozilla.org/show_bug.cgi?id=650078
split -new-instance flag out of existing -no-remote
flaghttps://bugzilla.mozilla.org/show_bug.cgi?id=716110

Notice how the devs cling to the belief that nobody uses the command line
on windows and that they usually try qualifying that misbelief by claiming
ignorance or retardation exists in said user base. Also note how instead of
actually addressing the core problem they've implemented many piss poor
patches intentionally. It's not that the core issue can't be rectified,
it's that the issue is deliberately left as it is. When I side stepped
their bullshit and provided a valid solution for you it was only after
having read the above linked bugzilla reports and about half a dozen more,
looking for a solution that might be merged into the source itself. This
isn't fun work at all, it's extremely irritating and I can say that after I
finished writing the redirector I decided that I was about sick of trying
to develop anything based on XULRunner. It's not just this command line
thing, it's that every time I turn around there are blocks put in the way
to any sort of rapid application development on windows. Those blocks
aren't accidental or lacking due to people not having developed solutions,
it's that every time there is some sort of headway in RAD on Windows the
dev team decides to implement another block to break said headway.
Seriously, it's total bullshit.

I've since switched to experimenting with
node-webkithttps://github.com/rogerwang/node-webkit
and appjs https://github.com/appjs/appjs when I'm not using InternetExplorer
object http://msdn.microsoft.com/en-us/library/aa752084(v=vs.85).aspx and
/ or System.Windows.Automationhttp://msdn.microsoft.com/en-us/library/system.windows.automation.aspx
because
I can get on with doing whatever I set out to do in the first place,
instead of screwing around with an intentionally difficult to use tool.
It's good stuff.

On Thu, Feb 21, 2013 at 6:24 PM, Laurent Jouanneau <notifications@github.com

wrote:

Why did you close this pull request ?

Did I say I don't want your contribution ? I just asked you a question
about this testResults directory. Ok, it shows results, but it is totally
useless in the repository. just remove it.


Reply to this email directly or view it on GitHubhttps://github.com//pull/12#issuecomment-13919668.

Matthew KastorContact Info_Phone:(616) 439-0091_Email:
matthewkastor@gmail.com_Google Profile:_
https://plus.google.com/100898583798552211130/posts*Blogger:*
http://matthewkastor.blogspot.com/*Github:*
https://github.com/matthewkastor?tab=repositories

Disclaimer

This email and any files transmitted with it are confidential, privileged,
and/or otherwise protected by work-product immunity or other legal rules.
This email and any files transmitted with it are intended solely for the
use of the individuals or entities to whom they are addressed. If you are
not the intended recipient, you are notified that disclosing, copying,
distributing or taking any action in reliance on the contents of this
information is strictly prohibited. If you have received this email in
error, please notify Mr. Kastor immediately. Mr. Kastor accepts no
liability for the content of this email or for the consequences of any
actions taken on the basis of the information provided.

WARNING: Computer viruses can be transmitted via email. The recipient
should check this email and any attachments for the presence of viruses.
Mr. Kastor accepts no liability for any damage caused by any virus
transmitted by this email. Email transmission cannot be guaranteed to be
secure or error-free, as information could be intercepted, corrupted, lost,
destroyed, arrive late or incomplete, or contain viruses. Mr. Kastor,
therefore, does not accept liability for any errors or omissions in the
contents of this message which arise as a result of email transmission.

Copyright notice

This email and its content is copyright of Matthew Kastor - © Matthew
Kastor 2013. All rights reserved.

Any transmission, redistribution, or reproduction of part or all of the
contents in any form is strictly prohibited. You may not, except with Mr.
Kastor's express written permission, distribute or commercially exploit the
content. You may not transmit it or store it in any other form of
electronic retrieval system other than the email system to which this
message was originally delivered. Any written permission granting use of
these contents must be notarized to be considered for validity.

@laurentj
Copy link
Owner

you completely ignored my awesome hackery

WHERE did you see I ignored your work ? If I want to ignore your work, I just have to close the pull request. But I didn't do that. I JUST asked you a question about your changes. This is called CODE REVIEW.

@laurentj
Copy link
Owner

thanks for your links to bugs on bugzilla.mozilla.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants