-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Firefox Console Redirector.exe #12
Conversation
Still gives error in phantom.jsm line 34
…, size, makeDirectory, removeDirectory
Conflicts: API.md bin/slimerjs.bat merge upstream master
Added superfluous looking check on SLIMERJSLAUNCHER. It fixes an issue where the batch file bails out while checking whether or not the path exists. Firefox Console Redirector should behave exactly as we intended the bat file to behave except the console redirection actually gets the output back to the console on windows. There aren't any temp files involved, it just works. I've put the help menu in and as far as I know it can replace the batch file. All we really need is for a few people to test it out. I compiled it for "Any CPU" so it should work on 32 and 64 bit systems.
Cleaned up the code that goes into making the executable for launching SlimerJs. Added a couple switches: /initialtests and /maintests that will run the initial-tests.js and main-tests.js. I've documented them in the console help. I ran the tests and copied the results into two text files. Windows fails a couple of the tests in main-tests.js. I couldn't read the results because of the shellcodes. They don't colorize the results on Windows, they just fill the screen with gibberish. I added a copy of the Wikipedia page that gives way too much information about the incompatibility of color codes in terminals. It sounds even worse than the inconsistencies between web browsers today. I deleted the batch file because it's useless now. I deleted Firefox Console Redirector.exe because SlimerJsRun.exe replaces it. I added GeckoLib.dll and Redirector.dll because SlimerJsRun.exe requires them. Redirector is a generic stderr stdout redirector for arbitrary processes. GeckoLib extends Redirector and adds some helper functions to make it easy to use with XULRunner, Firefox, Thunderbird, [conkeror](http://conkeror.org/), etc. etc. SlimerJsRun extends GeckoLib with a few functions specific to this project. I turned off the colors in Jasmine's output.
Why is there this test/testResults directory? I think it is useless. |
So is writing an application to redirect stupid console messages back to the original console instead of simply waiting for the user to acknowledge they've read the error before exiting the application. But... that's exactly what you wanted to do. Now I've made this stupid application, handed it to you, and all you have to say in response is that you don't like the file I left you that shows three failing tests. Well, you're welcome. |
Why did you close this pull request ? Did I say I don't want your contribution ? I just asked you a question about this testResults directory. Ok, it shows results, but it is totally useless in the repository. just remove it. |
From the desk of Matthew Kastor On this glorious Thursday, February 21, 2013 So... you were that rude on accident? I closed it because I wanted to delete my fork of slimerjs. I've got a repo When I submitted the pull request I did not expect you to do cartwheels and If you want to use the redirector you can find it at Relevant bugzilla links to command line retardation: Notice how the devs cling to the belief that nobody uses the command line I've since switched to experimenting with On Thu, Feb 21, 2013 at 6:24 PM, Laurent Jouanneau <notifications@github.com
Matthew KastorContact Info_Phone:(616) 439-0091_Email: Disclaimer This email and any files transmitted with it are confidential, privileged, WARNING: Computer viruses can be transmitted via email. The recipient This email and its content is copyright of Matthew Kastor - © Matthew Any transmission, redistribution, or reproduction of part or all of the |
WHERE did you see I ignored your work ? If I want to ignore your work, I just have to close the pull request. But I didn't do that. I JUST asked you a question about your changes. This is called CODE REVIEW. |
thanks for your links to bugs on bugzilla.mozilla.org |
Added superfluous looking check on
SLIMERJSLAUNCHER
. It fixes an issuewhere the batch file bails out while checking whether or not the path
exists.
Firefox Console Redirector should behave exactly as we intended the bat
file to behave except, the console redirection actually gets the output
back to the console on windows. There aren't any temp files involved, it
just works. I've put the help menu in and as far as I know it can
replace the batch file. All we really need is for a few people to test
it out. I compiled it for "Any CPU" so it should work on 32 and 64 bit
systems. One thing I don't like is that I couldn't find an asynchronous stream reader that would update the console on any input. As it stands, the best I found so far is the async. line reader. The redirected sterr and stdout from firefox show up in the console after every line break. So, if you test it out using the dump function from the firebug, jsconsole, scratchpad, etc. You'll have to add
\r
,\n
, or\r\n
to the end of your dump in order to flush it to the console immediately. I don't know if that's the same behavior as on other platforms.