Iterate inlining and simplification until we can do no more #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inlining can open up new opportunities for simplification. The rewriter tries to take advantage of this by doing two passes, but there can be chains of inlinable variables which can require an arbitrary number of passes. Instead, we can track whether or not we've inlined a variable this pass, and continue with further passes until we haven't found such a variable.
laurentlb
approved these changes
May 5, 2022
jwatzman
added a commit
to jwatzman/Shader_Minifier
that referenced
this pull request
May 11, 2022
The logic used in laurentlb#133 for when to iterate isn't quite right: it runs another pass when it detects an inlinable variable, not when it actually inlines. This means we sometimes run an extra pass (i.e., after removing an unused variable, we don't need to run another pass) and sometimes run too few passes (i.e., when inlining a variable we didn't "find" ourselves, such as an `i_blah` variable). Instead, we can use a very similiar technique but detecting when we actually do the inlining, not the finding.
laurentlb
pushed a commit
that referenced
this pull request
May 11, 2022
The logic used in #133 for when to iterate isn't quite right: it runs another pass when it detects an inlinable variable, not when it actually inlines. This means we sometimes run an extra pass (i.e., after removing an unused variable, we don't need to run another pass) and sometimes run too few passes (i.e., when inlining a variable we didn't "find" ourselves, such as an `i_blah` variable). Instead, we can use a very similiar technique but detecting when we actually do the inlining, not the finding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlining can open up new opportunities for simplification. The rewriter
tries to take advantage of this by doing two passes, but there can be
chains of inlinable variables which can require an arbitrary number of
passes. Instead, we can track whether or not we've inlined a variable
this pass, and continue with further passes until we haven't found such
a variable.