Allow inlining one-line functions #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentlb
approved these changes
May 12, 2022
This implements the simplest possible implementation of inlining functions. It only supports a function consisting of a single `return`, when it has been explicitly named as `i_whatever`. Basically, this works in cases where you might want to use a macro, excpet this gives the minifier full visibility through it. The simplicity of this implementation means that it's likely possible to get into trouble by marking certain functions as to-be-inlined. In particular, I'm pretty sure the following will break it: - inlining overloaded functions - inlining a function into a scope which has a local shadowing a global, where the inlined function refers to that global (though this will also break a macro)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the simplest possible implementation of inlining
functions. It only supports a function consisting of a single
return,when it has been explicitly named as
i_whatever. Basically, this worksin cases where you might want to use a macro, excpet this gives the
minifier full visibility through it.
The simplicity of this implementation means that it's likely possible to
get into trouble by marking certain functions as to-be-inlined. In
particular, I'm pretty sure the following will break it:
where the inlined function refers to that global (though this will
also break a macro)