Peephole optims, var scoping (fixes #153) #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentlb
approved these changes
Apr 18, 2024
src/rewriter.fs
Outdated
| | Decl (ty, [declElt]), (Expr (FunCall (Op "=", [Var name2; init2])) as assign2) | ||
| when declElt.name.Name = name2.Name | ||
| && not (exprUsesIdentName init2 declElt.name.Name) | ||
| && declElt.init |> Option.defaultValue (Int (0, "")) |> isPure -> |
There was a problem hiding this comment.
Can be written as:
declElt.init |> Option.map isPure |> Option.defaultValue true
or shorter:
declElt.init |> Option.forall isPure
| let exprUsesIdentName expr identName = | ||
| let mutable idents = [] | ||
| let collectLocalUses _ = function | ||
| | Var v as e -> idents <- v :: idents; e |
There was a problem hiding this comment.
Consider replacing idents with a boolean, if you just want to know if we've found identName
There was a problem hiding this comment.
I think it might be more useful to return the names, in case we want to search multiple names without visiting the tree multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.