Added unit tests for reports.

src/Report/UsersRightsReport.php

@@ -217,9 +217,6 @@ private function outputRoleUser(PdfGroupTable $table): void
      */
     private function outputUsers(array $users, PdfGroupTable $table): void
     {
-        if ([] === $users) {
-            return;
-        }
         foreach ($users as $user) {
             if (!$user->isOverwrite()) {
                 $rights = $this->builder->getRole($user)->getRights();

tests/Controller/AjaxControllerTest.php

@@ -0,0 +1,44 @@
+<?php
+/*
+ * This file is part of the Calculation package.
+ *
+ * (c) bibi.nu <bibi@bibi.nu>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace App\Tests\Controller;
+
+use App\Controller\AbstractController;
+use App\Controller\AjaxController;
+use PHPUnit\Framework\Attributes\CoversClass;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+
+#[CoversClass(AbstractController::class)]
+#[CoversClass(AjaxController::class)]
+class AjaxControllerTest extends AbstractControllerTestCase
+{
+    public static function getRoutes(): \Iterator
+    {
+        yield ['/ajax/task', self::ROLE_USER, Response::HTTP_OK, Request::METHOD_POST, true];
+        yield ['/ajax/task', self::ROLE_ADMIN, Response::HTTP_OK, Request::METHOD_POST, true];
+        yield ['/ajax/task', self::ROLE_SUPER_ADMIN, Response::HTTP_OK, Request::METHOD_POST, true];
+
+        $query = '/ajax/license?file=vendor/laurentmuller/fpdf2/LICENSE';
+        yield [$query, self::ROLE_USER, Response::HTTP_FORBIDDEN, Request::METHOD_GET, true];
+        yield [$query, self::ROLE_ADMIN, Response::HTTP_OK, Request::METHOD_GET, true];
+        yield [$query, self::ROLE_SUPER_ADMIN, Response::HTTP_OK, Request::METHOD_GET, true];
+
+        yield ['/ajax/random/text', self::ROLE_USER];
+        yield ['/ajax/random/text', self::ROLE_ADMIN];
+        yield ['/ajax/random/text', self::ROLE_SUPER_ADMIN];
+
+        yield ['/ajax/dialog/page', self::ROLE_USER];
+        yield ['/ajax/dialog/page', self::ROLE_ADMIN];
+        yield ['/ajax/dialog/page', self::ROLE_SUPER_ADMIN];
+    }
+}

tests/Controller/CalculationBelowControllerTest.php

@@ -13,17 +13,13 @@
 namespace App\Tests\Controller;
 
 use App\Controller\CalculationBelowController;
-use App\Report\CalculationsBelowReport;
-use App\Spreadsheet\CalculationsDocument;
 use App\Tests\EntityTrait\CalculationTrait;
 use App\Tests\EntityTrait\ProductTrait;
 use Doctrine\ORM\Exception\ORMException;
 use PHPUnit\Framework\Attributes\CoversClass;
 use Symfony\Component\HttpFoundation\Response;
 
 #[CoversClass(CalculationBelowController::class)]
-#[CoversClass(CalculationsBelowReport::class)]
-#[CoversClass(CalculationsDocument::class)]
 class CalculationBelowControllerTest extends AbstractControllerTestCase
 {
     use CalculationTrait;

tests/Controller/CalculationControllerTest.php

@@ -12,20 +12,16 @@
 
 namespace App\Tests\Controller;
 
+use App\Controller\AbstractController;
+use App\Controller\AbstractEntityController;
 use App\Controller\CalculationController;
-use App\Report\CalculationReport;
-use App\Report\CalculationsReport;
-use App\Spreadsheet\CalculationDocument;
-use App\Spreadsheet\CalculationsDocument;
 use App\Tests\EntityTrait\CalculationTrait;
 use App\Tests\EntityTrait\ProductTrait;
 use PHPUnit\Framework\Attributes\CoversClass;
 
+#[CoversClass(AbstractController::class)]
+#[CoversClass(AbstractEntityController::class)]
 #[CoversClass(CalculationController::class)]
-#[CoversClass(CalculationReport::class)]
-#[CoversClass(CalculationsReport::class)]
-#[CoversClass(CalculationDocument::class)]
-#[CoversClass(CalculationsDocument::class)]
 class CalculationControllerTest extends AbstractControllerTestCase
 {
     use CalculationTrait;

tests/Controller/CalculationDuplicateControllerTest.php

@@ -14,16 +14,12 @@
 
 use App\Controller\CalculationDuplicateController;
 use App\Entity\Product;
-use App\Report\CalculationsDuplicateReport;
-use App\Spreadsheet\CalculationsDuplicateDocument;
 use App\Tests\EntityTrait\CalculationTrait;
 use App\Tests\EntityTrait\ProductTrait;
 use PHPUnit\Framework\Attributes\CoversClass;
 use Symfony\Component\HttpFoundation\Response;
 
 #[CoversClass(CalculationDuplicateController::class)]
-#[CoversClass(CalculationsDuplicateReport::class)]
-#[CoversClass(CalculationsDuplicateDocument::class)]
 class CalculationDuplicateControllerTest extends AbstractControllerTestCase
 {
     use CalculationTrait;

tests/Controller/CalculationEmptyControllerTest.php

@@ -13,16 +13,12 @@
 namespace App\Tests\Controller;
 
 use App\Controller\CalculationEmptyController;
-use App\Report\CalculationsEmptyReport;
-use App\Spreadsheet\CalculationsEmptyDocument;
 use App\Tests\EntityTrait\CalculationTrait;
 use App\Tests\EntityTrait\ProductTrait;
 use PHPUnit\Framework\Attributes\CoversClass;
 use Symfony\Component\HttpFoundation\Response;
 
 #[CoversClass(CalculationEmptyController::class)]
-#[CoversClass(CalculationsEmptyReport::class)]
-#[CoversClass(CalculationsEmptyDocument::class)]
 class CalculationEmptyControllerTest extends AbstractControllerTestCase
 {
     use CalculationTrait;

tests/Controller/CalculationStateControllerTest.php

@@ -12,16 +12,16 @@
 
 namespace App\Tests\Controller;
 
+use App\Controller\AbstractController;
+use App\Controller\AbstractEntityController;
 use App\Controller\CalculationStateController;
-use App\Report\CalculationStatesReport;
-use App\Spreadsheet\CalculationStatesDocument;
 use App\Tests\EntityTrait\CalculationStateTrait;
 use PHPUnit\Framework\Attributes\CoversClass;
 use Symfony\Component\HttpFoundation\Response;
 
+#[CoversClass(AbstractController::class)]
+#[CoversClass(AbstractEntityController::class)]
 #[CoversClass(CalculationStateController::class)]
-#[CoversClass(CalculationStatesReport::class)]
-#[CoversClass(CalculationStatesDocument::class)]
 class CalculationStateControllerTest extends AbstractControllerTestCase
 {
     use CalculationStateTrait;

tests/Controller/CategoryControllerTest.php

@@ -12,16 +12,16 @@
 
 namespace App\Tests\Controller;
 
+use App\Controller\AbstractController;
+use App\Controller\AbstractEntityController;
 use App\Controller\CategoryController;
-use App\Report\CategoriesReport;
-use App\Spreadsheet\CategoriesDocument;
 use App\Tests\EntityTrait\CategoryTrait;
 use PHPUnit\Framework\Attributes\CoversClass;
 use Symfony\Component\HttpFoundation\Response;
 
+#[CoversClass(AbstractController::class)]
+#[CoversClass(AbstractEntityController::class)]
 #[CoversClass(CategoryController::class)]
-#[CoversClass(CategoriesReport::class)]
-#[CoversClass(CategoriesDocument::class)]
 class CategoryControllerTest extends AbstractControllerTestCase
 {
     use CategoryTrait;

tests/Controller/ChartControllerTest.php

@@ -13,17 +13,13 @@
 namespace App\Tests\Controller;
 
 use App\Controller\ChartController;
-use App\Report\CalculationByMonthReport;
-use App\Report\CalculationByStateReport;
 use App\Tests\EntityTrait\CalculationTrait;
 use App\Tests\EntityTrait\GlobalMarginTrait;
 use App\Tests\EntityTrait\ProductTrait;
 use PHPUnit\Framework\Attributes\CoversClass;
 use Symfony\Component\HttpFoundation\Response;
 
 #[CoversClass(ChartController::class)]
-#[CoversClass(CalculationByMonthReport::class)]
-#[CoversClass(CalculationByStateReport::class)]
 class ChartControllerTest extends AbstractControllerTestCase
 {
     use CalculationTrait;

tests/Controller/CustomerControllerTest.php

@@ -12,16 +12,16 @@
 
 namespace App\Tests\Controller;
 
+use App\Controller\AbstractController;
+use App\Controller\AbstractEntityController;
 use App\Controller\CustomerController;
 use App\Entity\Customer;
-use App\Report\CustomersReport;
-use App\Spreadsheet\CustomersDocument;
 use PHPUnit\Framework\Attributes\CoversClass;
 use Symfony\Component\HttpFoundation\Response;
 
+#[CoversClass(AbstractController::class)]
+#[CoversClass(AbstractEntityController::class)]
 #[CoversClass(CustomerController::class)]
-#[CoversClass(CustomersReport::class)]
-#[CoversClass(CustomersDocument::class)]
 class CustomerControllerTest extends AbstractControllerTestCase
 {
     private ?Customer $entity = null;

tests/Controller/GlobalMarginControllerTest.php

@@ -12,16 +12,16 @@
 
 namespace App\Tests\Controller;
 
+use App\Controller\AbstractController;
+use App\Controller\AbstractEntityController;
 use App\Controller\GlobalMarginController;
-use App\Report\GlobalMarginsReport;
-use App\Spreadsheet\GlobalMarginsDocument;
 use App\Tests\EntityTrait\GlobalMarginTrait;
 use PHPUnit\Framework\Attributes\CoversClass;
 use Symfony\Component\HttpFoundation\Response;
 
+#[CoversClass(AbstractController::class)]
+#[CoversClass(AbstractEntityController::class)]
 #[CoversClass(GlobalMarginController::class)]
-#[CoversClass(GlobalMarginsReport::class)]
-#[CoversClass(GlobalMarginsDocument::class)]
 class GlobalMarginControllerTest extends AbstractControllerTestCase
 {
     use GlobalMarginTrait;

tests/Controller/GroupControllerTest.php

@@ -12,16 +12,16 @@
 
 namespace App\Tests\Controller;
 
+use App\Controller\AbstractController;
+use App\Controller\AbstractEntityController;
 use App\Controller\GroupController;
-use App\Report\GroupsReport;
-use App\Spreadsheet\GroupsDocument;
 use App\Tests\EntityTrait\GroupTrait;
 use PHPUnit\Framework\Attributes\CoversClass;
 use Symfony\Component\HttpFoundation\Response;
 
+#[CoversClass(AbstractController::class)]
+#[CoversClass(AbstractEntityController::class)]
 #[CoversClass(GroupController::class)]
-#[CoversClass(GroupsReport::class)]
-#[CoversClass(GroupsDocument::class)]
 class GroupControllerTest extends AbstractControllerTestCase
 {
     use GroupTrait;