This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
Fix for clearing scope.expMonth and scope.expYear when scope.expiry is used in the form #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ared appropriately, causing use of scope.expiry to use the previous expiry month and expiry year when submitting the form a second time.
Closed
|
This is a better fix than #22 and should be implemented instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19 by setting scope.expMonth and scope.expYear to null if scope.expiry was used in the form. The values for scope.expMonth and scope.expYear are not cleared if they are used in the form.