Remove broken agrep test entry (fails with bash >= 5.2)

[Vogtinator]

It's meant to cause agrep to return with exit code 2, but asserts that it's exit code 1 instead.

It's meant to ensure that using .* as pattern results in exit code 2 because it matches also an empty string. However, glob expansion results in .* picking up files such as . and .. from the CWD, which get interpreted as valid pattern. This results in exit status 1 (no match found) which is what the .ok file expects, but that's invalid.

With bash 5.2, glob expansion no longer matches . and .. by default, so the test works as intended by accident, causing a mismatch with the expected wrong exit code.

It's unfortunately not easily possible to avoid glob expansion in this case.

Just remove the test for now.

[trushworth]

Bash 4.4 (and up) and sh seem to have a "noglob" option to disable shell globbing. Would it make sense to add
set -f
and
set +f
to tests/agrep/run-tests.sh around the line that ends up doing the unwanted globbing? I'll see if I can set up something to test the before and after cases. If it solves the problem then exitstatus.ok will need to be updated too.

[trushworth]

I tried the 'set -f' idea and it worked just fine in FreeBSD, Linux, and MacOS, so I've gone with that approach. Thank you very much for the diagnosis though, the problem would have been much much more work to figure out without it!