Add support for default credentials providers. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `s3_id`, `s3_secret`, and `profile` to be omitted. If they are, the Ruby SDK will fall back to the default credentials providers, which can use environment variables, credentials files, or IAM role information stored in instance metadata. The motivation of this change is to bring configure-s3-website closer to s3_website, which supports configuration with omitted credentials.
|
Thanks for the PR, I’ll try to take a look at it at some point (busy with other commitments at the moment). |
|
Thanks @jzuber4! This pull request is now released in the latest versions of this gem and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
s3_id,s3_secret, andprofileto be omitted. If they are, the Ruby SDK will fall back to the default credentials providers, which can use environment variables, credentials files, or IAM role information stored in instance metadata.The motivation of this change is to bring configure-s3-website closer to s3_website, which supports configuration with omitted credentials.