Compatibility with GHC 8.4 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this builds on GHC-8.4 -- it would be nice to get this merged in as |
|
Ping! @kylcarte -- It would be great to get this merged and uploaded to hackage. It would be nice to release hasktorch (the haskell bindings to torch) "as-is" with the |
|
Currently unable to build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHC 8.4 completely changes the definition/nature of
==from Data.Type.Equality; it is no longer an open type family, so the previous instance in Type.Family.Nat no longer builds. Instead, the new==makesNatEqredundant, soNatEqis could now be defined in terms of==(instead of the other way around).Addresses #8.
(Note this PR also includes some patches/rebases to sync up the repository with the one currently on hackage, since HEAD on github atm does not build.)