Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Upgrading to vue-cli 4 and electron 8 #135

Merged
merged 3 commits into from May 17, 2020
Merged

Upgrading to vue-cli 4 and electron 8 #135

merged 3 commits into from May 17, 2020

Conversation

mszkb
Copy link
Contributor

@mszkb mszkb commented May 3, 2020

According to: #94

What I have done:
Complete revamp of folder structure

  • upgrading vue-cli 4
  • use vue-cli-plugin-electron-builder for project scaffolding
  • upgrading to electron 8
  • upgrading to spectron 10
  • use jest instead of karma, mocha and chai
  • moving configurations into vue.config.js
  • upgrading to prettier 2

We do not need following files/directories anymore, because they are managed by vue-cli-plugin-electron-builder:

  • .electron-vue build files
  • Karma tests
  • seperate renderer and main folders in src

I left the code as it was before. There is a new version to prettier and I applied the codestyling.

@mszkb
Copy link
Contributor Author

mszkb commented May 3, 2020

Sadly it is pretty hard to check what I have done to the sourcecode itself because I moved everything into the src/ folder instead splitting up into main and renderer.

@lauthieb
Copy link
Owner

lauthieb commented May 4, 2020

Thank you very much @mszkb. I will check this in the following days.

@lauthieb
Copy link
Owner

@mszkb sorry I don't have time for now :'(
I will check that max on Saturday. Thanks a lot.

@lauthieb
Copy link
Owner

Wow amazing work.
All scripts works well. Thanks again @mszkb!

@lauthieb lauthieb merged commit 8d64b09 into lauthieb:master May 17, 2020
@lauthieb
Copy link
Owner

@mszkb there's a problem...
When I did npm run build:mac and installed with the new 1.2.4 dmg file, I've lost all my notes. Fortunately, when I reinstall the 1.2.3 version my notes come back.
Can you please check this problem?
I will let your commit on master but don't make a release until this work again.
Thanks!

@mszkb
Copy link
Contributor Author

mszkb commented May 21, 2020

I try to replicate and fix this problem on my machine over the weekend :)

@lauthieb
Copy link
Owner

Thanks a lot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants