Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for netx mishandling scalar input dimension #156

Merged
merged 34 commits into from Jan 13, 2023
Merged

Conversation

bamsumit
Copy link
Contributor

Issue Number: 149

Objective of pull request:
Netx had issue handling scalar input dimension. This PR fixes it.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • Loading such a network runs into error.

What is the new behavior?

  • Network is loaded properly

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit bamsumit linked an issue Jan 13, 2023 that may be closed by this pull request
14 tasks
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit bamsumit merged commit 5aab428 into lava-nc:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error loading '.net' model with netx.hdf5
2 participants